add basepath support #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $this->assertSame('DirectAction', $actual->values['action']); | ||
|
|
||
| // should get the basepath in place | ||
| $expect = '/path/to/sub/index.php/foo/bar'; |
There was a problem hiding this comment.
good to have one more test with no index.php . So is /path/to/sub/foo/bar
|
Thank you @pmjones . This looks good to me. |
|
Thank You @pmjones //...
$this->basepath = rtrim($basepath, ' /');to the Router constructor for handling params like '/path/to/sub/' |
|
Added a dir-only test, and added rtrim. When the CI passes, I'll merge it. Thanks guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be a fix for #86 -- @harikt @pine3ree please review and comment.
Basically, you create a RouterFactory with the basepath you want; that would be the subdirectory in which the application lives. You can then add routes as normal, without having to specify the basepath prefix; the matcher will match properly, and the generator will generate paths with the basepath prefix in place.