Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow entry script in subdir #30

Closed
wants to merge 1 commit into from
Closed

Conversation

pine3ree
Copy link

@pmjones
Copy link
Member

pmjones commented Jul 17, 2015

@pine3ree Now that Aura.Router 2.3.0 is available with $basepath support, do you want to try using it and see if it resolves this issue? In theory, you should be able to add $di->params['Aura\Router\Router']['basepath'] = '/path/to/subdir'; in your project-level config file define() method, and it should work.

@pmjones
Copy link
Member

pmjones commented Jul 17, 2015

Also, on further consideration, this PR is only a partial fix, as it doesn't address paths generated from routes (which I only thought of in the past couple of days). As such, I'm closing the PR, but please do try the new Aura.Router and let me know if it works to solve this problem for you.

@pmjones pmjones closed this Jul 17, 2015
@pine3ree
Copy link
Author

Hello @pmjones,

i performed some tests with the new router. It seems to work fine now.

PS
About the "path generated by routes"... didn't you just add

//line 205 Router
return $this->basepath . $this->generator->generate($route, $data);

to achieve a correct url building?
Or do you wish to have the generator as well to be aware of the basepath setting (same way you did for the router) and thus creating the full path by itself?

kind regards,
maks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants