fix(webpack): fix missing postcss in less/scss/styl processing #1153
Conversation
3cp
force-pushed
the
fix-missing-postcss
branch
from
7d74162 to
f00b0de
Compare
3cp
force-pushed
the
fix-missing-postcss
branch
from
f00b0de to
00c9628
Compare
|
release check passed. |
| @@ -222,8 +222,7 @@ module.exports = ({ production } = {}, {extractCss, analyze, tests, hmr, port, h | |||
| issuer: [{ not: [{ test: /\.html$/i }] }], | |||
| use: extractCss ? [{ | |||
| loader: MiniCssExtractPlugin.loader | |||
| }, | |||
| 'css-loader' | |||
| }, ...cssRules | |||
There was a problem hiding this comment.
This is not directly related to the changes. I have noticed that at present CSS modules have not been used. Is it better to add support for that too? If you decide to do so then, it might not make sense to import the CSS (modules) in HTML as the original local name will take no effect, as the names will be morphed (BTW which actually works vNext, with the help of convention I believe :)).
There was a problem hiding this comment.
The cssRules is 'css-loader' plus postcss. I think the previous line was missed when introducing cssRules into the code. The previous line missed postcss setup which is a bug.
Yes, there is no css-modules offered in Aurelia 1 skeletons.
There was a problem hiding this comment.
Well, this fixed the issue for me, thank you @3cp. I tested it on my project (SASS based) and can confirm that build works well. Because I'm not using extractCss in that project, I missed the similar issue for css files, so again, thank you for noticing that.
closes #1152
@graycrow @Sayan751 please review this fix. At mean while, I am going to run through release check on webpack.