Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser.executeScript doesn't take a callback #6

Closed
jonabc opened this issue Apr 23, 2017 · 1 comment
Closed

browser.executeScript doesn't take a callback #6

jonabc opened this issue Apr 23, 2017 · 1 comment

Comments

@jonabc
Copy link

jonabc commented Apr 23, 2017

I'm submitting a bug report

  • Library Version:
    1.0.2

Please tell us about your environment:

  • Operating System:
    OSX 10.12

  • Node Version:
    7.9.0

  • NPM Version:
    4.2.0

  • Browser:
    Chrome

  • Language:
    ESNext

Current behavior:
Running e2e tests from aurelia-skeleton skeleton-esnext-webpack project result in the following
screen shot 2017-04-23 at 12 27 38 am

Expected/desired behavior:

  1. Clone aurelia-skeleton and use skeleton-esnext-webpack
  2. At time of writing there are two minor blockers that need to be fixed to continue
  • update package.json for invalid babel-loader "next" tag
"devDependencies": {
...
  "babel-loader": "^7.0.0"
...
}
  • update .babelrc.js for invalid "useBuiltIns": true (I think the correct option now is "usage")
"presets": [
...
        "useBuiltIns": "usage"
...
]
  1. npm install
  2. npm start -- e2e
@niieani
Copy link
Contributor

niieani commented Apr 24, 2017

Hey, thanks for the report. Indeed, I investigated the same problem and I'm working on a solution. For now, feel free to use version 1.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants