fix(typescript-webpack-experimental): Replace executeAyncScript with executeScript #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…executeScript Fixes the issue described in: aurelia/skeleton-navigation#714 (comment) Previously when the app was larger it would wait to emit the events before protractor was loaded, however due to the speed increase introduced by the experimental webpack configuration, aurelia was initialising and emitting the event before protractor had a chance to listen to it, hence it would hang indefinitely. Telling the browser to execute the script synchronously will delay aurelia long enough for protractor to register its listeners before aurelia emits the event itself.
|
|
24 tasks
|
Thank you. |
|
@niieani Please release this. I already have the issue in my project with just a few more components ;) |
|
Oh, didn't realize it wasn't! I've CC'd @EisenbergEffect about releasing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue described in: aurelia/skeleton-navigation#714 (comment)
Previously when the app was larger it would wait to emit the events before
protractor was loaded, however due to the speed increase introduced by
the experimental webpack configuration, aurelia was initialising and emitting
the event before protractor had a chance to listen to it, hence it would hang
indefinitely. Telling the browser to execute the script synchronously will
delay aurelia long enough for protractor to register its listeners before
aurelia emits the event itself.
This solution was provided by @niieani.