Move Docker image to new repo, use dev-only image #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #34, development tools were added to the clitest Docker image, making it both an end user image and a development environment. This was a bad idea. This commit separates them in two different images. - The public clitest image was moved to a new repository: https://github.com/aureliojargas/clitest-docker. Now everything is automated and releasing a new clitest image to Docker Hub is just a matter of adding a git tag to that repository. Everything related to that image was removed from this repository. - The local development image remains here, named `clitest-dev` and described in the new `Dockerfile.dev` file. It does not have clitest inside it, it's just the development environment. When running the image, the current clitest code should be mounted inside it. In short, everything dev-related is here. After releasing a new clitest version (here), go to the other repository to make the official Docker image for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #34, development tools were added to the clitest Docker image, making
it both an end user image and a development environment. This was a bad
idea.
This commit separates them in two different images.
The public clitest image was moved to a new repository:
https://github.com/aureliojargas/clitest-docker. Now everything is
automated and releasing a new clitest image to Docker Hub is just a
matter of adding a git tag to that repository. Everything related to
that image was removed from this repository.
The local development image remains here, named
clitest-devanddescribed in the new
Dockerfile.devfile. It does not have clitestinside it, it's just the development environment. When running the
image, the current clitest code should be mounted inside it.
In short, everything dev-related is here. After releasing a new clitest
version (here), go to the other repository to make the official Docker
image for it.