Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort when --post-flight command fails #41

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Conversation

aureliojargas
Copy link
Owner

Previously, any error when running the --post-flight command was
ignored. The rationale was that all the "real" tests were already
executed, being the post-flight a mere non-fatal cleanup action.

Now any failure in that step is fatal.
Just like it already is with --pre-flight.

The user specifically asked for a cleanup task to be run, and should be
notified on any error during its execution. If this is an optional task
for the user, he/she can just add a || true at the end so that it
always succeeds, even in case of errors.

Previously, any error when running the `--post-flight` command was
ignored. The rationale was that all the "real" tests were already
executed, being the post-flight a mere non-fatal cleanup action.

Now any failure in that step is fatal.
Just like it already is with `--pre-flight`.

The user specifically asked for a cleanup task to be run, he/she should
be notified on any error during its execution. If this is an optional
task for the user, he/she can just add a `|| true` at the end so that it
always succeeds, even in case of errors.
@aureliojargas aureliojargas merged commit bab2d55 into master Jul 1, 2020
@aureliojargas aureliojargas deleted the post-flight-verify branch July 1, 2020 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant