Abort when --post-flight command fails #41
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, any error when running the
--post-flight
command wasignored. The rationale was that all the "real" tests were already
executed, being the post-flight a mere non-fatal cleanup action.
Now any failure in that step is fatal.
Just like it already is with
--pre-flight
.The user specifically asked for a cleanup task to be run, and should be
notified on any error during its execution. If this is an optional task
for the user, he/she can just add a
|| true
at the end so that italways succeeds, even in case of errors.