Add different networks to makefile #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuajbouw
force-pushed
the
makefile-options
branch
3 times, most recently
from
332668b to
8bda35a
Compare
joshuajbouw
force-pushed
the
makefile-options
branch
from
8bda35a to
6a18045
Compare
birchmd
approved these changes
Jul 21, 2021
| @@ -24,5 +24,4 @@ res/ | |||
| etc/state-migration-test/target/ | |||
|
|
|||
| node_modules/* | |||
| artifacts/ | |||
There was a problem hiding this comment.
Its a duplicate, just a nit that I noticed.
Its still there: https://github.com/aurora-is-near/aurora-engine/blob/makefile-options/.gitignore#L18
artob
added a commit
that referenced
this pull request
Jul 30, 2021
* JSON: fix bugs and add unit tests. (#141) * Add storage layout debug support for `EvmErc20.sol`. (#178) * ERC-20: forbid using invalid NEP-141 AccountID for mapping. (#179) * Add EIP-2930 support. (#181, #182) * Migrate all workflows to self-hosted runners. (#185) * Speed up the workflow using build caching. (#189) * Use the new math API host functions. (#190) * Fix `clippy::enum_variant_names` warning. (#192) * Add different networks to the Makefile. (#193) * Update the network status in the README. (#194) * Remove the toolchain installation step in workflows. (#195) * Run all tests for all networks in CI. (#196) * Optimize for performance instead of code size. (#197) * Parallelize the test suites. (#198) * Add build-caching to the testing workflow. (#201) * Refactor tests to use Signer. (#203) * Add options to the bench profile. (#204) * Remove a duplicate test. (#205) * Add a sanity test for access list handling. (#206) * Update nearcore to the latest branch. * Add feature gates to the SDK's new host functions. Co-authored-by: Ahmed Ali <ahmed@aurora.dev> Co-authored-by: Dmitry Strokov <dmitry@aurora.dev> Co-authored-by: Evgeny Ukhanov <evgeny@aurora.dev> Co-authored-by: Joshua J. Bouw <joshua@aurora.dev> Co-authored-by: Kirill <kirill@aurora.dev> Co-authored-by: Michael Birch <michael@aurora.dev>
This was referenced Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have testnet specific code with an upcoming PR #190, this adds the ability to compile for different networks. This prevents accidental compilation for the wrong network.
This does make some rather large changes. For one, it doesn't make symlinks. I am somewhat predicting that in the current setup it is way too easy to accidentally upload the wrong .wasm file to the wrong network. I make it more explicit. Instead of symlinks, this now copies the WASM file to the root folder with explicit names like
mainnet-release.wasm.Todo:
There does need to be a follow-up PR that will include CI testing for each network release.