Implement `AsyncAurora` contract #489

karim-en · 2022-04-15T12:42:20Z

Implement AsyncAurora contract to support Aurora Cross Contract Calls

sept-en

Some minor comments while it's still draft. More comments will be added when it's not a draft anymore

sept-en · 2022-04-15T13:37:34Z

etc/async-aurora/src/lib.rs

+                promise_desc.gas,
+            );
+
+            promises.push(promise.clone());


This is a redundant clone, let's avoid this

Fixed at 77836d8

sept-en · 2022-04-15T13:39:02Z

etc/async-aurora/src/lib.rs

+#[ext_contract(ext_bridge_token_factory)]
+pub trait ExtBridgeTokenFactory {
+    #[result_serializer(borsh)]
+    fn finish_withdraw(
+        &self,
+        #[serializer(borsh)] amount: Balance,
+        #[serializer(borsh)] recipient: AccountId,
+    ) -> Promise;
+}
+


It seems this is redundant and left here after the migration from the other repo.

Suggested change

#[ext_contract(ext_bridge_token_factory)]

pub trait ExtBridgeTokenFactory {

#[result_serializer(borsh)]

fn finish_withdraw(

&self,

#[serializer(borsh)] amount: Balance,

#[serializer(borsh)] recipient: AccountId,

) -> Promise;

}

Fixed at acbf0b0

sept-en · 2022-04-15T13:40:43Z

etc/async-aurora/src/lib.rs

+    combinator: Option<CombinatorDescription>,
+}
+
+fn parse_promises(input: String) -> Vec<PromiseDescription> {


This rather should be the part of the appropriate trait.

fixed at acbf0b0

…a-is-near/aurora-engine into cross-contracts-call-async

joshuajbouw · 2022-04-18T10:14:41Z

Just be aware, that we need to have DAO approval for this.

* Change input args type * Fix parsing promises * Add gas parameter

sept-en

Added some more comments and questions for discussions. Also, please add README for async-aurora with appropriate references to cross-contract-call and native token connector design discussions.

sept-en · 2022-04-26T00:39:37Z

engine-tests/src/tests/res/TestAsync.sol

+        string memory accountId,
+        string memory method,
+        uint128 arg,
+        string memory gas


Why do we use gas as a string even in tests?

Fixed at d4e17fc

sept-en · 2022-04-26T00:46:39Z

engine-tests/src/tests/async_aurora.rs

+        }
+    }
+
+    fn submit(context: &TestContext, input: Vec<u8>) {


Let's make the meaning clear

Suggested change

fn submit(context: &TestContext, input: Vec<u8>) {

fn call_aurora_async_submit(context: &TestContext, input: Vec<u8>) {

fixed at bfe5844

sept-en · 2022-04-26T00:51:16Z

engine-tests/src/tests/async_aurora.rs

+            .assert_success();
+    }
+
+    fn caller_simple_call(context: &TestContext, method: String, arg: u128) {


Let's add this prefix instead of caller in all these test functions

Suggested change

fn caller_simple_call(context: &TestContext, method: String, arg: u128) {

fn exec_testasync_simple_call(context: &TestContext, method: String, arg: u128) {

Fixed at f004ca6

sept-en · 2022-04-26T02:35:17Z

etc/async-aurora/src/lib.rs

+        let promises_str = ethabi::decode(&[ethabi::ParamType::String], output.as_slice())
+            .unwrap()
+            .pop()
+            .unwrap()
+            .to_string()
+            .unwrap();
+        let promises_desc = parse_promises(promises_str);
+        let mut promises: Vec<Promise> = Vec::with_capacity(promises_desc.len());
+        for promise_desc in promises_desc {
+            let mut promise = Promise::new(promise_desc.target.clone())
+                .function_call(
+                    promise_desc.method_name.clone(),
+                    promise_desc.arguments.clone(),
+                    0,
+                    promise_desc.gas,
+                )
+                .as_return();
+
+            if let Some(combinator) = &promise_desc.combinator {
+                match combinator.combinator_type {
+                    CombinatorType::And => {
+                        promise = promises[combinator.promise_index as usize]
+                            .clone()
+                            .and(promise);
+                    }
+                    CombinatorType::Then => {
+                        promise = promises[combinator.promise_index as usize]
+                            .clone()
+                            .then(promise);
+                    }
+                }
+            }
+
+            promises.push(promise);
+        }
+    }


For a discussion: do we want to have lazy-promise execution? This way we may need to ask the user to attach enough ETH to pay for the storage needed to store promises in async.aurora before they are executed. Also, we will need to have a precompile allowing the user to execute unfinished promises that are already stored in async.aurora in some mapping (execution_id: Vec<Promise>)

sept-en · 2022-04-26T02:57:46Z

etc/async-aurora/src/lib.rs

+use near_sdk::borsh::{self, BorshDeserialize, BorshSerialize};
+use near_sdk::{assert_self, env, ext_contract, near_bindgen, Gas, Promise};
+
+pub const GAS_RESERVED_FOR_CURRENT_CALL: Gas = 20_000_000_000_000;


Suggesting changing the name. Also, are you sure 20 TGas will be enough? What's the real usage value?

Suggested change

pub const GAS_RESERVED_FOR_CURRENT_CALL: Gas = 20_000_000_000_000;

pub const GAS_RESERVED_FOR_SUBMIT: Gas = 20_000_000_000_000;

Fixed at bfe5844

sept-en · 2022-04-26T02:58:27Z

etc/async-aurora/Cargo.toml

+name = "async-aurora"
+version = "0.1.0"
+authors = ["Aurora <hello@aurora.dev>"]
+edition = "2021"
+publish = false
+


let's also add the description.

Fixed at f004ca6

sept-en · 2022-04-26T13:46:56Z

engine-precompiles/src/async_router.rs

+    near_account_to_evm_address(predecessor_account_id.as_bytes())
+}
+
+impl Precompile for AsyncRouter {


Another idea would be to implement AsyncRouter as a regular Solidity contract and create a precompile that will call that router contract. The router contract could be deployed using a separate function (e.g. deploy_router_contract().

Yes, this is the point of contention, I also preferred the regular solidity contract, but I got request to implement it as precompile

joshuajbouw · 2022-04-27T08:39:52Z

Please keep this as a draft. There is still a lot to discuss about this.

* Add description * Rename call method

sept-en · 2022-05-26T10:34:38Z

etc/async-aurora-test/src/engine_types.rs

+use near_sdk::borsh::{self, BorshDeserialize, BorshSerialize};
+
+pub type EthAddress = [u8; 20];
+pub type RawU256 = [u8; 32];
+/// Wei compatible Borsh-encoded raw value to attach an ETH balance to the transaction
+pub type WeiU256 = [u8; 32];
+


NB: this file is being replicated twice in both etc/async-aurora-test and etc/async-aurora. Moreover, it shouldn't be duplicated there, rather should be separated into a separate lib in the repo itself.

bharath-123 · 2022-07-20T06:19:34Z

Would this also cover querying a NEAR contract? It is great that we can call a NEAR contract, but i would like to understand if this feature would allow us to query a NEAR contract method too?

birchmd · 2022-09-07T12:38:35Z

Closing this as cross-contract calls were implemented in #560

karim-en added 2 commits April 11, 2022 03:18

Implement AsyncAurora contract

511fc76

Implement AsyncAurora contract

ac6b359

sept-en suggested changes Apr 15, 2022

View reviewed changes

karim-en added 4 commits April 18, 2022 06:13

AsyncAurora: fix submit call input type

e3512e6

AsyncAurora: implement sim tests

2dbb852

Merge branch 'cross-contracts-call-async' of https://github.com/auror…

72fcd95

…a-is-near/aurora-engine into cross-contracts-call-async

AsyncAurora: code cleanup

acbf0b0

mfornet self-requested a review April 18, 2022 09:29

karim-en added 3 commits April 20, 2022 22:34

AsyncAurora: multiple improvments and fixes.

2a61312

* Change input args type * Fix parsing promises * Add gas parameter

Fix and improve AsyncAurora tests

fb824fb

Remove unused type

260492b

karim-en force-pushed the cross-contracts-call-async branch from 0068f30 to 260492b Compare April 20, 2022 21:35

karim-en added 2 commits April 25, 2022 14:27

AsyncAurora: refactor call_back

77836d8

AsyncAurora: run cargo fmt

9fc61b6

sept-en suggested changes Apr 26, 2022

View reviewed changes

Implement async router precompile

f00e853

sept-en reviewed Apr 26, 2022

View reviewed changes

Async router: add tests and minor bug fixes

bfe5844

karim-en marked this pull request as ready for review April 27, 2022 00:05

karim-en requested a review from joshuajbouw as a code owner April 27, 2022 00:05

joshuajbouw marked this pull request as draft April 27, 2022 08:40

karim-en added 2 commits May 12, 2022 01:34

Change parameter type for gas

d4e17fc

Minor improvments:

f004ca6

* Add description * Rename call method

karim-en force-pushed the cross-contracts-call-async branch from 7a91456 to f004ca6 Compare May 12, 2022 00:59

sept-en reviewed May 26, 2022

View reviewed changes

birchmd closed this Sep 7, 2022

aleksuss deleted the cross-contracts-call-async branch October 16, 2023 10:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement `AsyncAurora` contract #489

Implement `AsyncAurora` contract #489

karim-en commented Apr 15, 2022

sept-en left a comment

sept-en Apr 15, 2022

karim-en May 11, 2022

sept-en Apr 15, 2022

karim-en May 11, 2022

sept-en Apr 15, 2022

karim-en May 12, 2022

joshuajbouw commented Apr 18, 2022

sept-en left a comment

sept-en Apr 26, 2022

karim-en May 12, 2022

sept-en Apr 26, 2022

karim-en May 12, 2022

sept-en Apr 26, 2022

karim-en May 12, 2022

sept-en Apr 26, 2022

sept-en Apr 26, 2022

karim-en May 11, 2022

sept-en Apr 26, 2022

karim-en May 12, 2022

sept-en Apr 26, 2022

karim-en May 11, 2022

joshuajbouw commented Apr 27, 2022

sept-en May 26, 2022

bharath-123 commented Jul 20, 2022

birchmd commented Sep 7, 2022

	fn submit(context: &TestContext, input: Vec<u8>) {
	fn call_aurora_async_submit(context: &TestContext, input: Vec<u8>) {

	fn caller_simple_call(context: &TestContext, method: String, arg: u128) {
	fn exec_testasync_simple_call(context: &TestContext, method: String, arg: u128) {

	pub const GAS_RESERVED_FOR_CURRENT_CALL: Gas = 20_000_000_000_000;
	pub const GAS_RESERVED_FOR_SUBMIT: Gas = 20_000_000_000_000;

Implement AsyncAurora contract #489

Implement AsyncAurora contract #489

Conversation

karim-en commented Apr 15, 2022

sept-en left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joshuajbouw commented Apr 18, 2022

sept-en left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joshuajbouw commented Apr 27, 2022

Choose a reason for hiding this comment

bharath-123 commented Jul 20, 2022

birchmd commented Sep 7, 2022

Implement `AsyncAurora` contract #489

Implement `AsyncAurora` contract #489