Feat: standalone nep141 legacy #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrLSD
changed the title
birchmd
reviewed
Feb 2, 2023
There was a problem hiding this comment.
Nice idea with the flag in the state to indicate if the legacy code can be disabled! I still think a more general solution involving the engine version would be better because it would generalize to other changes we might want to make, but this gets the job done for this case.
joshuajbouw
approved these changes
Feb 2, 2023
aleksuss
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After splitting logic in #607 - Split NEP-141 from Engine,
engine-standalonerequires changes. Sinceengine-standalonecannot interact with the newaurora-eth-connectprcontract, the previous NEP-141-related codebase has been moved separately tostandalone-nep141-legacy. This will ensure thatengine-standaloneworks well with historical data.Modules were added:
legacy_connectorfungible_tokenPerformance / NEAR gas cost considerations
It affects only standalone. So no side effects.
Testing
Tests not changed for standalone. Just restored expected behaviour. For some unknown reason failed function
validate_standalone, but that function don't affect any test.