Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update some rust dependencies #673

Merged
merged 1 commit into from
Feb 1, 2023
Merged

chore: update some rust dependencies #673

merged 1 commit into from
Feb 1, 2023

Conversation

aleksuss
Copy link
Member

Description

The PR updates some rust dependencies and extends aurora-engine-sdk crate with two functions for base64 en/decoding.

@aleksuss aleksuss requested review from mrLSD, 0x3bfc and birchmd January 31, 2023 14:10
@aleksuss aleksuss requested a review from joshuajbouw as a code owner January 31, 2023 14:10
@aleksuss aleksuss added C-dependencies Category: Pull requests that update a dependency rust Pull requests that update Rust code labels Jan 31, 2023
mrLSD
mrLSD approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@mrLSD mrLSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand borsh 0.10 was not updated because incompatible with test dependencies.

@aleksuss
Copy link
Member Author

As I understand borsh 0.10 was not updated because incompatible with test dependencies.

Yes. We use unwrap_borsh from near-sdk-sim which depends on borsh 0.9.3.

@aleksuss aleksuss merged commit 8d66ae6 into develop Feb 1, 2023
@aleksuss aleksuss deleted the chore/update_dependencies branch February 1, 2023 10:20
birchmd pushed a commit that referenced this pull request Apr 5, 2023
@aleksuss @birchmd
chore: update some rust dependencies (#673)
4ce6884
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birchmd birchmd birchmd approved these changes

@joshuajbouw joshuajbouw joshuajbouw approved these changes

@0x3bfc 0x3bfc 0x3bfc approved these changes

@mrLSD mrLSD mrLSD approved these changes

Assignees
No one assigned
Labels
C-dependencies Category: Pull requests that update a dependency rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aleksuss @mrLSD @0x3bfc @joshuajbouw @birchmd