feat: splitting nep-141 logic (silo) #748
Conversation
…o feat/split-eth-connector
…o feat/split-eth-connector
aleksuss
force-pushed
the
feat/aleksuss/silo-slitting-nep141
branch
from
9c5a0e5
to
49e2ccf
Compare
|
Why was this cloned from #607? |
|
Because we want to apply changes related to splitting NEP-141 to Aurora EVM with SILO logic first. |
aleksuss
changed the title
There was a problem hiding this comment.
Halfway through. Will review later just wanted to post these so you can start addressing them.
Those, the public interface of the Engine contract has not changed. However, these functions now work differently. Inside them, there is a cross-contract call of the functions of another contract - aurora-eth-connector
One question: the linked PR says there are no gas cost changes. Aren't xcc's more expensive? Or it's not significant? I guess in most cases users would interact directly with the nep-141 contract instead of calling it through the engine as a proxy, so I suppose for practical purposes there are no gas cost changes, correct?
|
The gas costs are affected by previous changes from the |
aleksuss
force-pushed
the
feat/aleksuss/silo
branch
from
eb4195d
to
fd05d8f
Compare
aleksuss
force-pushed
the
feat/aleksuss/silo-slitting-nep141
branch
from
e56c73b
to
0dba29e
Compare
|
Adding the status do not merge, as it'll be good to go for the release following the upcoming one. |
# Conflicts: # .github/workflows/tests.yml # Cargo.lock # Cargo.toml # Makefile.toml # engine-standalone-nep141-legacy/src/fungible_token.rs # engine-standalone-storage/Cargo.toml # engine-standalone-storage/src/sync/mod.rs # engine-tests/Cargo.toml # engine-tests/src/tests/erc20_connector.rs # engine-tests/src/tests/eth_connector.rs # engine-tests/src/tests/mod.rs # engine-tests/src/tests/repro.rs # engine-tests/src/tests/sanity.rs # engine-tests/src/tests/state_migration.rs # engine-tests/src/tests/uniswap.rs # engine-tests/src/tests/xcc.rs # engine-tests/src/utils/mod.rs # engine-tests/src/utils/standalone/mocks/mod.rs # engine-types/src/parameters/mod.rs # engine/src/connector.rs # engine/src/lib.rs # engine/src/parameters.rs
…ing-nep141 # Conflicts: # Cargo.lock # engine-standalone-storage/src/sync/mod.rs # engine-tests/src/utils/mod.rs # engine-workspace/src/contract.rs # engine-workspace/src/operation.rs # engine/src/lib.rs
aleksuss
force-pushed
the
feat/aleksuss/silo-slitting-nep141
branch
from
0dba29e
to
72e04ba
Compare
|
Closed in flavour #813 |
Description
This PR is a clone of #607
Performance / NEAR gas cost considerations
Testing
How should this be reviewed
Additional information