fix: setting erc-20 metadata by the owner of the contract #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birchmd
approved these changes
Oct 26, 2023
aleksuss
added a commit
that referenced
this pull request
Oct 26, 2023
## Description The PR fixes behaviour when the owner of the smart contract can't set ERC-20 metadata in case the account id of the owner and the account id of the contract are different. ## Performance / NEAR gas cost considerations There are no changes in the performance. ## Testing The corresponding test has been added.
aleksuss
added a commit
that referenced
this pull request
Oct 26, 2023
## Description The PR fixes behaviour when the owner of the smart contract can't set ERC-20 metadata in case the account id of the owner and the account id of the contract are different. ## Performance / NEAR gas cost considerations There are no changes in the performance. ## Testing The corresponding test has been added.
Merged
aleksuss
added a commit
that referenced
this pull request
Oct 26, 2023
mrLSD
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR fixes behaviour when the owner of the smart contract can't set ERC-20 metadata in case the account id of the owner and the account id of the contract are different.
Performance / NEAR gas cost considerations
There are no changes in the performance.
Testing
The corresponding test has been added.