Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump nearcore to 2.4.0 rc.1, Rust toolchain to 1.82.0 #183

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

alexander-borodulya
Copy link
Contributor

@alexander-borodulya alexander-borodulya commented Nov 20, 2024

Reason for updating the Rust toolchain to 1.82.0

A borealis-engine-lib build pointing to nearcore 2.4.0-rc.1 has failed due to a version conflict between the syn crate versions required by different dependencies:

  1. thiserror-impl v2.0.0 requires syn ^2.0.87.
  2. actix-macros v0.2.4 requires syn ^2.0.79.
borealis-engine-lib % cargo check
    Updating git repository `https://github.com/near/nearcore`
    Updating crates.io index
error: failed to select a version for `syn`.
    ... required by package `thiserror-impl v2.0.0`
    ... which satisfies dependency `thiserror-impl = "=2.0.0"` of package `thiserror v2.0.0`
    ... which satisfies dependency `thiserror = "^2.0"` of package `near-crypto v2.4.0-rc.1 (https://github.com/near/nearcore?tag=2.4.0-rc.1#a83c1849)`
    ... which satisfies git dependency `near-crypto` of package `aurora-refiner-types v0.29.0-2.4.0-rc.1 (/Path/to/borealis-engine-lib/refiner-types)`
    ... which satisfies path dependency `aurora-refiner-types` of package `aurora-refiner v0.29.0-2.4.0-rc.1 (/Path/to/borealis-engine-lib/refiner-app)`
versions that meet the requirements `^2.0.87` are: 2.0.87

all possible versions conflict with previously selected packages.

  previously selected package `syn v2.0.79`
    ... which satisfies dependency `syn = "^2"` (locked to 2.0.79) of package `actix-macros v0.2.4`
    ... which satisfies dependency `actix-macros = "^0.2"` (locked to 0.2.4) of package `actix v0.13.5`
    ... which satisfies dependency `actix = "=0.13.5"` (locked to 0.13.5) of package `aurora-refiner v0.29.0-2.4.0-rc.1 (/Path/to/borealis-engine-lib/refiner-app)`

failed to select a version for `syn` which could resolve this conflict

Updating deps to the latest compatible versions and running cargo check again shows:

borealis-engine-lib % cargo update
    Updating crates.io index
    ...
borealis-engine-lib % cargo check
error: rustc 1.81.0 is not supported by the following packages:
  near-chunks@2.4.0-rc.1 requires rustc 1.82.0
  near-client@2.4.0-rc.1 requires rustc 1.82.0
  near-epoch-manager@2.4.0-rc.1 requires rustc 1.82.0
  near-indexer@2.4.0-rc.1 requires rustc 1.82.0
  near-jsonrpc@2.4.0-rc.1 requires rustc 1.82.0
  near-jsonrpc-client@2.4.0-rc.1 requires rustc 1.82.0
  near-mainnet-res@2.4.0-rc.1 requires rustc 1.82.0
  near-network@2.4.0-rc.1 requires rustc 1.82.0
  near-network@2.4.0-rc.1 requires rustc 1.82.0
  near-network@2.4.0-rc.1 requires rustc 1.82.0
  near-performance-metrics-macros@2.4.0-rc.1 requires rustc 1.82.0
  near-pool@2.4.0-rc.1 requires rustc 1.82.0
  near-rosetta-rpc@2.4.0-rc.1 requires rustc 1.82.0
  near-store@2.4.0-rc.1 requires rustc 1.82.0
  near-telemetry@2.4.0-rc.1 requires rustc 1.82.0
  near-wallet-contract@2.4.0-rc.1 requires rustc 1.82.0
  near-wallet-contract@2.4.0-rc.1 requires rustc 1.82.0
  near-wallet-contract@2.4.0-rc.1 requires rustc 1.82.0
  nearcore@2.4.0-rc.1 requires rustc 1.82.0
  node-runtime@2.4.0-rc.1 requires rustc 1.82.0
Either upgrade rustc or select compatible dependency versions with
`cargo update <name>@<current-ver> --precise <compatible-ver>`
where `<compatible-ver>` is the latest version supporting rustc 1.81.0

@alexander-borodulya alexander-borodulya merged commit 288446a into main Nov 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants