feat: add transfer recovery from lock/withdraw hash #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paouvrard
changed the title
chadoh
approved these changes
Mar 15, 2021
| @@ -85,6 +86,93 @@ export function checkStatus (transfer) { | |||
| } | |||
| } | |||
|
|
|||
| // Recover transfer from a withdraw tx hash | |||
| // Track a new transfer at the completedStep = WITHDRAW so that it can be unlocked | |||
There was a problem hiding this comment.
It's not hooked up yet, but most other comments throughout this repo use typedoc-style notation so that we can generate great documentation, whether people are relying on inline docs in their editor or viewing it on the web.
/**
* Recover transfer from a withdraw tx hash.
* Track a new transfer at the completedStep = WITHDRAW so that it can be unlocked
* @param withdrawTxHash hash of ...
*/
export async function ...| nearOnEthClientBlockHeights: [], | ||
| proofs: [] | ||
| } | ||
| track(transfer) |
There was a problem hiding this comment.
This appears to be mostly copied from initiate. How complicated would it be to extract to a separate function?
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for aurora-is-near/rainbow-bridge-frontend#136
Given an eth lock hash or a near withdraw hash, recreate a transfer object which can be finalized (mint/unlock)