compatibility with stable #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the need for `core::intrinsics` by adding an implementation of the relevant intrinsic. For wasm32-unknown-unknown target, this should result in virtually identical generated code.
matklad
added a commit
to matklad/aurora-engine
that referenced
this pull request
Jan 26, 2022
This pulls in near/wasmer#106 which should allow us to upgrade the nightly version we use. An alternative would be to pull in aurora-is-near/rjson#1, which should (0.7 confidence) allow us to switch to stable.
matklad
added a commit
to matklad/aurora-engine
that referenced
this pull request
Jan 26, 2022
This pulls in near/wasmer#106 which should allow us to upgrade the nightly version we use. An alternative would be to pull in aurora-is-near/rjson#1, which should (0.7 confidence) allow us to switch to stable.
|
Actually, I just realized that I wanted to ask @nagisa to take a look here as well -- they probably know a better way to fix this :) |
|
For the face value the changes seem reasonably good to me, but I'd probably be somewhat worried about the ability for this sort of implementation to correctly round the parsed fractional numbers. I haven't dug deeply enough into the code to understand why |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the need for
core::intrinsicsby adding an implementationof the relevant intrinsic. For wasm32-unknown-unknown target, this
should result in virtually identical generated code.