Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Refactore EOFMAGIC check creation #59

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Fix: Refactore EOFMAGIC check creation #59

merged 2 commits into from
Aug 27, 2024

Conversation

mrLSD
Copy link
Member

@mrLSD mrLSD commented Aug 27, 2024

Description

Related to issue #58.

◀️ Refactored contract creation code check from Opcode(0xEF) to just integer
➡️ Added EVM error CreateContractStartingWithEF

⚠️ Opcode removal is in PR #57

@mrLSD mrLSD self-assigned this Aug 27, 2024
@mrLSD mrLSD added the bug Something isn't working label Aug 27, 2024
aleksuss
aleksuss reviewed Aug 27, 2024
View reviewed changes
core/src/error.rs Outdated Show resolved Hide resolved
@mrLSD mrLSD requested a review from aleksuss August 27, 2024 10:23
@mrLSD mrLSD requested a review from birchmd August 27, 2024 10:30
@mrLSD mrLSD added the enhancement New feature or request label Aug 27, 2024
@mrLSD mrLSD added this to the v0.45.4 milestone Aug 27, 2024
@mrLSD mrLSD merged commit 1d9d1dc into master Aug 27, 2024
6 checks passed
@mrLSD mrLSD deleted the fix/eof-creation-code branch August 27, 2024 14:24
@mrLSD mrLSD mentioned this pull request Aug 27, 2024
Closed
mrLSD added a commit that referenced this pull request Sep 5, 2024
@mrLSD
Feat: Refactor and add new Opcodes (#57)
60e17ef 
* Refactored Opcodes. Implements: EIP-4399, EIP-7069

* Fix: Refactore EOFMAGIC check creation (#59)

* Refactore EOFMAGIC code creation, issue #58

* Change index CreateContractStartingWithEF to 16

* Added new Opcodes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksuss aleksuss aleksuss approved these changes

@birchmd birchmd birchmd approved these changes

Assignees

@mrLSD mrLSD

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
v0.45.4-aurora
Development

Successfully merging this pull request may close these issues.
3 participants
@mrLSD @aleksuss @birchmd