Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exodus Mesh, boundary condition, and block data transfer functionality implementation. #11

Merged
merged 7 commits into from
Sep 5, 2022

Conversation

TheBEllis
Copy link
Collaborator

A PR to add all of the exodus transfer stuff I've done.To try and make this a bit cleaner, instead of rebasing my current exodus transfer branch I have just made a copy of the current master branch and just put all my changes in there. I know this is sinful as it will remove the commit history from the meshing work I've done, but rebasing was causing big headaches and this way it ensures everything is the same as the master, apart from the changes needed for the meshing.

I have tried to sufficiently comment the createMFEMMesh() method in CoupledMFEMMesh.C to make it a bit more readable. It is still a bit ugly but some of that might just be inherent as creating all these data structures that are only really needed for mesh creation is a bit wordy for lack of a better word. I have added an example input file and exodus mesh to the examples/MFEM/rod directory, which does the joule rod problem just with an exodus mesh as the input and translating that to the MFEM mesh. I have done the tiniest bit of benchmarking, using the hypervapotron mesh the createMFEMMesh() took approx 700 ms to run. Don't currently have anything to compare to so I don't know if this is good or bad, but in completely qualitative terms, for a 75000 element mesh, that seems alright (I think?). Quicker than writing out VTK's anyway ;)

Copy link
Contributor

@alexanderianblair alexanderianblair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for adding the dockerfile MUMPS update and stripping the timing calls as discussed.

This will make it substantially simpler to test MOOSE examples for coupled runs, given the number of exodus meshes used in them!

src/mesh/CoupledMFEMMesh.C Outdated Show resolved Hide resolved
@alexanderianblair alexanderianblair merged commit d729525 into master Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants