Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable transfer of distributed MOOSE mesh (v1: distributed MOOSE --> MFEMMesh --> MFEMParMesh) #32

Merged
merged 7 commits into from
Oct 3, 2023
Merged

Enable transfer of distributed MOOSE mesh (v1: distributed MOOSE --> MFEMMesh --> MFEMParMesh) #32

merged 7 commits into from
Oct 3, 2023

Conversation

EdwardPalmer99
Copy link
Contributor

@EdwardPalmer99 EdwardPalmer99 commented Sep 15, 2023 •
edited
Loading

Changes:

  1. MFEMMesh objects can now be created on each processor from a distributed MOOSE mesh.
  2. Added getFirstElementOnProcessor method to CoupledMFEMMesh. This returns a pointer to the first element on the processor.
  3. Added a distributed mesh transfer test.

Limitations:

  1. Currently no way to directly go from a distributed MOOSE mesh to an MFEMParMesh. This will be a separate PR.
  2. To go from a distributed MOOSE to an MFEMParMesh requires building an MFEMMesh object on each processor. While this is still in memory, an MFEMParMesh is constructed from the MFEMMesh. This requires a much higher memory footprint than going directly.

Added getFirstElementOnProcessor method to CoupledMFEMMesh. It is now…
8cb0b9b 
… possible to create an MFEMMesh from a distributed MOOSE mesh.
@EdwardPalmer99 EdwardPalmer99 added bug Something isn't working enhancement New feature or request labels Sep 15, 2023
alexanderianblair
alexanderianblair approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@alexanderianblair alexanderianblair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo - but otherwise good!

test/tests/unit/distributed_transfers/tests
exodiff = 'elemental_var_coupled_out.e'
max_parallel = 2
min_parallel = 2
requirement = 'Apollo shall have the transfer from distributed MOOSE meshes'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in requirement line - assume it should read '...have the ability to set up a coupled MFEM mesh from...' or similar?

@alexanderianblair alexanderianblair merged commit 3136e0d into master Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderianblair alexanderianblair alexanderianblair approved these changes

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EdwardPalmer99 @alexanderianblair