Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

au/static_cast_checkers.hh missing from CMakeLists.txt #359

Closed
chiphogg opened this issue Dec 15, 2024 · 1 comment · Fixed by #360
Closed

au/static_cast_checkers.hh missing from CMakeLists.txt #359

chiphogg opened this issue Dec 15, 2024 · 1 comment · Fixed by #360
Labels
⬇️ affects: code (interfaces) Affects the way end users will interact with the library 📁 kind: bug Something isn't working correctly, or there's a mistake 💪 effort: small
Milestone

Comments

@chiphogg
Copy link
Contributor

I started messing around with releasing a new conan version, and got an unexpected build error. Turns out that, yep, #347 did not update CMakeLists.txt. I need to figure out why our CI didn't catch it. Using CMake locally, everything does still pass. I suspect it's related to having an external project use Au as a dependency. We'll need to cut a new release for this ASAP.

@chiphogg chiphogg added 📁 kind: bug Something isn't working correctly, or there's a mistake 💪 effort: small ⬇️ affects: code (interfaces) Affects the way end users will interact with the library labels Dec 15, 2024
chiphogg added a commit that referenced this issue Dec 15, 2024
This makes sure that clients can use a version of Au that is installed
by CMake.

Fixes #359.
chiphogg added a commit that referenced this issue Dec 15, 2024
This makes sure that clients can use a version of Au that is installed
by CMake.

Fixes #359.
@chiphogg chiphogg added this to the 0.4.1 milestone Dec 15, 2024
@chiphogg
Copy link
Contributor Author

For posterity: the tool in #379 would have prevented this issue from occurring in the first place if we had created it and made it gating.

chiphogg added a commit that referenced this issue Jan 21, 2025
This will prevent future issues similar to #359 from occurring in the
first place.

Fixes #255.
chiphogg added a commit that referenced this issue Jan 21, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
This will prevent future issues similar to #359 from occurring in the
first place.

Fixes #255.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⬇️ affects: code (interfaces) Affects the way end users will interact with the library 📁 kind: bug Something isn't working correctly, or there's a mistake 💪 effort: small
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant