-
Notifications
You must be signed in to change notification settings - Fork 29
Make separate workflow for each build config #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This will enable us to give each config its own badge. We can display these badges prominently on our README file. We can also add them to the new page we'll add which clarifies which configurations we support.
timhirsh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I like the badges
Also, my plan is to remove the required build-and-test checks in the repo settings once this lands, and then add the new versions of the jobs.
Small clarification: the old versions of the required checks are going to block you from merging this. So you'll need 3 phases:
- disable current required build checks
- merge
- enable new required builds checks
|
Right... that was what I was picturing in my head. Honest! 😄 |
|
Click "View details" above to see the job names that motivated #155: Also, just confirming that the badges did indeed turn green. 🙂 |
On a recent PR (#154), basically every job's status was reported as either "build", or "build / build". We should make these more descriptive so it's easier to tell what's what.

This will enable us to give each config its own badge. We can display
these badges prominently on our README file. We can also add them to
the new page we'll add which clarifies which configurations we support.