Skip to content

Conversation

@chiphogg
Copy link
Member

This will enable us to give each config its own badge. We can display
these badges prominently on our README file. We can also add them to
the new page we'll add which clarifies which configurations we support.

chiphogg added 3 commits July 26, 2023 15:18
This will enable us to give each config its own badge.  We can display
these badges prominently on our README file.  We can also add them to
the new page we'll add which clarifies which configurations we support.
@chiphogg chiphogg requested a review from timhirsh July 26, 2023 21:04
@chiphogg chiphogg marked this pull request as ready for review July 26, 2023 21:04
@chiphogg chiphogg requested a review from a team as a code owner July 26, 2023 21:04
@chiphogg
Copy link
Member Author

chiphogg commented Jul 26, 2023

Status badges:

clang14-ubuntu
clang11-ubuntu
gcc10-ubuntu

MSVC x64 19.29
MSVC-x64-19.35.32217.1

I think these should all go from "grey" to "green" once we land this to main.

Also, my plan is to remove the required build-and-test checks in the repo settings once this lands, and then add the new versions of the jobs.

@chiphogg chiphogg added the release notes: ⚙️ repo PR affecting the way the repository works label Jul 26, 2023
Copy link
Member

@timhirsh timhirsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I like the badges

Also, my plan is to remove the required build-and-test checks in the repo settings once this lands, and then add the new versions of the jobs.

Small clarification: the old versions of the required checks are going to block you from merging this. So you'll need 3 phases:

  • disable current required build checks
  • merge
  • enable new required builds checks

@chiphogg
Copy link
Member Author

Right... that was what I was picturing in my head. Honest! 😄

@chiphogg chiphogg merged commit ef7032e into main Jul 26, 2023
@chiphogg chiphogg deleted the separate-jobs#144 branch July 26, 2023 22:02
@chiphogg
Copy link
Member Author

Click "View details" above to see the job names that motivated #155:

image

Also, just confirming that the badges did indeed turn green. 🙂

chiphogg added a commit that referenced this pull request Jul 27, 2023
On a recent PR (#154), basically every job's status was reported as
either "build", or "build / build".  We should make these more
descriptive so it's easier to tell what's what.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: ⚙️ repo PR affecting the way the repository works

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants