Correctly stream out quantities with a char Rep #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quantities that have a `char` `Rep` will have the resulting raw number streamed as a `char`. Given that a Quantity is a number, users would expect that a the value would be streamed as the integral number, not interpreted as a character code.
|
|
chiphogg
added
the
release notes: 🐛 lib (bugfix)
chiphogg
approved these changes
Feb 5, 2024
Member
chiphogg
left a comment
chiphogg
left a comment
There was a problem hiding this comment.
Thanks for finding and fixing the bug, and including a test!
I think you'll need to sign the CLA before I can merge, even though it's somewhat of a formality in your case. (I know you work for Aurora, but unfortunately our tooling can't currently know that!)
chiphogg
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quantities that have a
charRepwill have the resulting raw numberstreamed as a
char. Given that a Quantity is a number, users wouldexpect that a the value would be streamed as the integral number, not
interpreted as a character code.