Tweak corresponding quantity for main chrono types #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we have a single generic correspondence for all chrono
durations. This is perfectly unit safe, but it means we have no labels
for any duration type, including common types like `std::chrono::hours`.
This means that `as_quantity(std::chrono::hours{3})` would print as
`"3 [UNLABELED UNIT]"` instead of `"3 h"`.
This PR defines a special correspondence for each commonly used chrono
duration type, which fixes the above behaviour.
As part of doing this, we found a missing dependency on `:quantity`, so
we added it in the BUILD file.
Fixes #216.
chiphogg
added
the
release notes: ✨ lib (enhancement)
hoffbrinkle
approved these changes
Aug 4, 2024
Co-authored-by: Michael Hordijk <hoffbrinkle@gmail.com>
geoffviola
approved these changes
Aug 5, 2024
Contributor
geoffviola
left a comment
geoffviola
left a comment
There was a problem hiding this comment.
Looks useful. Tests look good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we have a single generic correspondence for all chrono
durations. This is perfectly unit safe, but it means we have no labels
for any duration type, including common types like
std::chrono::hours.This means that
as_quantity(std::chrono::hours{3})would print as"3 [UNLABELED UNIT]"instead of"3 h".This PR defines a special correspondence for each commonly used chrono
duration type, which fixes the above behaviour.
As part of doing this, we found a missing dependency on
:quantity, sowe added it in the BUILD file.
Fixes #216.