Add common_unit and make_common utilities
#362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We also add the "common point" versions of these. The absence of `common_unit` and `common_point_unit` was mostly just an oversight. I recently tried to call one in Godbolt, and got surprised when I couldn't. And it turned out that I had already written this function anyway, except that it was hidden away inside of a test file. As I thought about these functions more, I thought it was interesting that the inputs are unit slots, so we could have a wide variety of things (simple units, quantity makers, unit symbols, etc.), but the output would always be a simple unit. Wouldn't it be nice if we could also combine `meters` and `feet`, or `m` and `ft`, and have the output act like its inputs? This idea became the `make_common` and `make_common_point` utilities. Docs included (and rendered and tested).
chiphogg
added
release notes: ✨ lib (enhancement)
geoffviola
approved these changes
Dec 18, 2024
Contributor
geoffviola
left a comment
geoffviola
left a comment
There was a problem hiding this comment.
Implementation, tests, and docs look good. Just left some minor comments.
| } | ||
|
|
||
| TEST(MakeCommon, PreservesCategory) { | ||
| constexpr auto feeters = make_common(feet, meters); |
hoffbrinkle
reviewed
Dec 18, 2024
Co-authored-by: Michael Hordijk <hoffbrinkle@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also add the "common point" versions of these.
The absence of
common_unitandcommon_point_unitwas mostly just anoversight. I recently tried to call one in Godbolt, and got surprised
when I couldn't. And it turned out that I had already written this
function anyway, except that it was hidden away inside of a test file.
As I thought about these functions more, I thought it was interesting
that the inputs are unit slots, so we could have a wide variety of
things (simple units, quantity makers, unit symbols, etc.), but the
output would always be a simple unit. Wouldn't it be nice if we could
also combine
metersandfeet, ormandft, and have the outputact like its inputs? This idea became the
make_commonandmake_common_pointutilities.Docs included (and rendered and tested).