Handle lowest signed integrals in get_value
#447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we can't represent `-mag<128>()` in `int8_t`, even though the value `-128` _is_ representable. The problem is that we're using the max of the type to decide what we can represent, and then just negating it. This special case logic enables us to handle all integer values correctly. Helps pave the way for #349.
hoffbrinkle
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we can't represent
-mag<128>()inint8_t, even though thevalue
-128is representable. The problem is that we're using themax of the type to decide what we can represent, and then just negating
it. This special case logic enables us to handle all integer values
correctly.
Helps pave the way for #349.