Implement limits for OpSequence
#458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it all comes together. We carefully designed the overflow checkers for each individual operation so that they took a `Limits` parameter, which might be different from the full limits for the type. This PR adds a `LimitsFor<Op, Limits>` helper, which takes an "output target" limits type `Limits`, and an operation `Op`, and produces the _input limits_ that will stay within that target. And this object can be used as the "limits" parameter _for the previous operation in the chain_! And we're done. Helps #349.
Member
Author
Sure is! But it took a lot of hard work to make it that easy. 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it all comes together. We carefully designed the overflow checkers
for each individual operation so that they took a
Limitsparameter,which might be different from the full limits for the type. This PR
adds a
LimitsFor<Op, Limits>helper, which takes an "output target"limits type
Limits, and an operationOp, and produces the inputlimits that will stay within that target. And this object can be used
as the "limits" parameter for the previous operation in the chain!
And we're done.
Helps #349.