Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Improvement on Python API #621

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

cmpute
Copy link
Contributor

@cmpute cmpute commented Dec 2, 2020

I did some changes to the python version API:

  1. Point clouds and images are stored separately to improve serialization performance of large point cloud
  2. Add type hints to builder classes for better class inference
  3. Remove the logger option as the logging in Python is handled in a different way from Javascript. The logging module provides centralized management, so I change the code to directly used the default logger for better clarity and easier maintenance.

@twojtasz twojtasz self-requested a review December 7, 2020 07:09
@twojtasz
Copy link
Contributor

twojtasz commented Dec 7, 2020

Looking at this now.

@CLAassistant
Copy link

CLAassistant commented Jan 20, 2022

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants