Skip to content
This repository has been archived by the owner on Apr 2, 2023. It is now read-only.

Probabilistic priority queueing #322

Merged
merged 38 commits into from
Oct 16, 2021
Merged

Probabilistic priority queueing #322

merged 38 commits into from
Oct 16, 2021

Conversation

lenhattan86
Copy link
Collaborator

Description:

The change enables soft priority queueing for aurora-scheduler.
If pending Task A has higher priority than other pending tasks, it has more chance to be scheduled than other pending tasks.
However, it does not mean that low priority tasks have to wait until all higher priority tasks scheduled. So, we do not starve any pending tasks.
The chance of scheduling is calculated using an exponential function p^exp where p is the priority and exp is the exponent.
We control exp using probabilistic_priority_assigner_exponent.

If exp is 0, there is no priority queueing.
if exp is high, there is less chance that the lower priority tasks can be scheduled.

Testing Done:

  • unit tests
  • local cluster tests.

@lenhattan86 lenhattan86 requested review from ridv and zorro786 October 6, 2021 02:26
Copy link
Collaborator

@zorro786 zorro786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First quick pass

Copy link
Collaborator

@zorro786 zorro786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second pass

@lenhattan86 lenhattan86 requested a review from zorro786 October 12, 2021 21:35
Copy link
Collaborator

@zorro786 zorro786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lenhattan86 There are several commits in this PR that are not related, it must be from a stale branch merge. Once those are fixed, PR LGTM.

@lenhattan86
Copy link
Collaborator Author

@lenhattan86 There are several commits in this PR that are not related, it must be from a stale branch merge. Once those are fixed, PR LGTM.

right, they are merged from master to fix other issues. However, none of them cause conflicts if you look at the list of changed files. https://github.com/aurora-scheduler/scheduler/pull/322/files

@zorro786
Copy link
Collaborator

@lenhattan86 There are several commits in this PR that are not related, it must be from a stale branch merge. Once those are fixed, PR LGTM.

right, they are merged from master to fix other issues. However, none of them cause conflicts if you look at the list of changed files. https://github.com/aurora-scheduler/scheduler/pull/322/files

I am not worried about conflicts, but for commit history and number of commits/messages. Once squashed and merged those older commit messages will also be part of single commit.

@lenhattan86
Copy link
Collaborator Author

@lenhattan86 There are several commits in this PR that are not related, it must be from a stale branch merge. Once those are fixed, PR LGTM.

right, they are merged from master to fix other issues. However, none of them cause conflicts if you look at the list of changed files. https://github.com/aurora-scheduler/scheduler/pull/322/files

I am not worried about conflicts, but for commit history and number of commits/messages. Once squashed and merged those older commit messages will also be part of single commit.

sure will clean them up when merging

Copy link
Collaborator

@zorro786 zorro786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ridv ridv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits: LGTM

lenhattan86 and others added 5 commits October 15, 2021 19:07
…ticPriorityAssigner.java

Co-authored-by: Renán I. Del Valle <github@ridv.xyz>
…ticPriorityAssigner.java

Co-authored-by: Renán I. Del Valle <github@ridv.xyz>
…ticPriorityAssigner.java

Co-authored-by: Renán I. Del Valle <github@ridv.xyz>
…ticPriorityAssigner.java

Co-authored-by: Renán I. Del Valle <github@ridv.xyz>
@lenhattan86 lenhattan86 merged commit e7a186f into aurora-scheduler:master Oct 16, 2021
@lenhattan86 lenhattan86 added this to the 0.26.0 milestone Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants