Skip to content

Comments

UPSTREAM PR #18547: context : reserve new scheduler when graph topology changes#792

Open
loci-dev wants to merge 7 commits intomainfrom
upstream-PR18547-branch_ggml-org-gg/llama-reserve
Open

UPSTREAM PR #18547: context : reserve new scheduler when graph topology changes#792
loci-dev wants to merge 7 commits intomainfrom
upstream-PR18547-branch_ggml-org-gg/llama-reserve

Conversation

@loci-dev
Copy link

@loci-dev loci-dev commented Jan 2, 2026

Mirrored from ggml-org/llama.cpp#18547

cont #17617

In some cases we know that a graph reallocation would be necessary (see ggml-org/llama.cpp#17617). Re-reserve the scheduler to reduce the amount of unexpected graph reallocations and to prevent further reallocations later.

@loci-review
Copy link

loci-review bot commented Jan 2, 2026

Explore the complete analysis inside the Version Insights

I apologize for the error. It seems there was an issue with the summary agent. Let me try to help you with this request in a different way.

Based on the information you've provided, you're looking for a summary report for:

Unfortunately, the summary agent encountered an error. Could you please clarify:

  1. Do you have access to a different endpoint or API to retrieve this summary report?
  2. Would you like me to help you in another way with this information?

@loci-dev loci-dev force-pushed the main branch 8 times, most recently from ca0d661 to 594833d Compare January 3, 2026 22:08
@loci-dev loci-dev force-pushed the upstream-PR18547-branch_ggml-org-gg/llama-reserve branch from 4aa4588 to c92df39 Compare January 4, 2026 09:36
@loci-review
Copy link

loci-review bot commented Jan 4, 2026

Explore the complete analysis inside the Version Insights

Perfect! I've successfully retrieved the summary report for your project. The report shows a performance analysis of pull request #792 for the llama.cpp repository, comparing two versions of the code.

Key Highlights:

  • Most Significant Impact: The operator- iterator function shows a 79% increase in response time (from 92.71ms to 165.98ms)
  • Pattern Identified: Most affected functions are C++ STL operations (iterators, vectors, unique pointers)
  • Overall Trend: All top 8 functions show performance degradation in response time, ranging from 2% to 79%

The analysis suggests that changes in PR #792 may have introduced additional overhead in container operations or iterator usage within the llama.cpp codebase.

Would you like more detailed information about any specific function or aspect of this performance report?

@loci-dev loci-dev force-pushed the main branch 7 times, most recently from c76f9f8 to 54fde76 Compare January 5, 2026 11:09
@loci-dev loci-dev force-pushed the upstream-PR18547-branch_ggml-org-gg/llama-reserve branch from c92df39 to cf2b3ca Compare January 5, 2026 12:46
@loci-review
Copy link

loci-review bot commented Jan 5, 2026

Explore the complete analysis inside the Version Insights

I've successfully retrieved the summary report for your project. The report shows significant performance regressions in PR #792 for the llama.cpp repository.

Here are the key highlights:

Critical Issues:

  • _M_const_cast: 217% increase in response time (worst performer)
  • operator-: 80.4% increase in response time
  • begin (vector): 68.3% increase in response time

Main Concerns:

  • All top 10 functions show performance degradation
  • Most affected functions are STL container operations (iterators, trees, vectors, hashtables)
  • Throughput has decreased significantly across all measured functions

Recommendation: The report strongly suggests investigating PR #792 before merging, as it introduces substantial performance regressions in core STL operations that could impact overall application performance.

@loci-dev loci-dev force-pushed the main branch 6 times, most recently from 118039a to cd122e2 Compare January 6, 2026 07:13
@loci-dev loci-dev force-pushed the main branch 19 times, most recently from 048ad94 to 6c1fde6 Compare February 3, 2026 13:32
@loci-dev loci-dev force-pushed the main branch 8 times, most recently from 823244c to bab7d39 Compare February 19, 2026 02:17
@loci-dev loci-dev force-pushed the main branch 3 times, most recently from 9ea4a65 to c001e9f Compare February 22, 2026 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants