This repository has been archived by the owner on May 24, 2024. It is now read-only.
Initial implementation of GraphQL support #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hatsat32
approved these changes
Jun 1, 2022
|
Hi Pete. There have been a lot of changes since the last release. So, we can release a new version if it is OK for you. |
|
Good morning Süleyman! Yes, I think it makes sense to do a new release with the last few fixes and features, especially views which is one of the major features that was missing. Perfectly OK for me, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #197
The only issue that unfortunately cannot be fixed that easily is that the NetBox test framework could not be convinced to test GraphQL APIs for plugins.
This is due to the fact that the test framework is quite inflexible and actually not supported for plugins at all - so we'll need to wait until support for the test framework (which, according to the NetBox maintainers, will probably require a general cleanup that is planned for a future release) until we can use it.