This repository has been archived by the owner on May 24, 2024. It is now read-only.
Set TTL for the zones' NS records to None #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #242
This very small change sets a zone's default TTL to None for all new and updated zones, as well as for all existing zones via a data migration.
As a result, NS records will still follow the zone's default TTL if the zone data are created with a
$TTLtag or similar mechanism in place (which is recommended anyway to avoid falling back to the SOAMINIMUM_TTLsetting for successful queries).@hatsat32: This PR can't be merged together with #240 as both have migrations. That needs to be fixed when the merge conflict pops up.