feat(ui): make name property for repos (argoproj#20077)

* name-option-added Signed-off-by: Surajyadav <harrypotter1108@gmail.com> * lint Signed-off-by: Surajyadav <harrypotter1108@gmail.com> --------- Signed-off-by: Surajyadav <harrypotter1108@gmail.com> Signed-off-by: austin5219 <3936059+austin5219@users.noreply.github.com>
austin5219 · Oct 16, 2024 · 9a105af · 9a105af
1 parent 6118c81
commit 9a105af
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 9 deletions.
diff --git a/ui/src/app/settings/components/repo-details/repo-details.tsx b/ui/src/app/settings/components/repo-details/repo-details.tsx
@@ -17,6 +17,11 @@ export const RepoDetails = (props: {repo: models.Repository; save?: (params: New
                 title: 'Repository URL',
                 view: repository.repo
             },
+            {
+                title: 'Name',
+                view: repository.name || '',
+                edit: (formApi: FormApi) => <FormField formApi={formApi} field='name' component={Text} />
+            },
             {
                 title: 'Username (optional)',
                 view: repository.username || '',
@@ -29,13 +34,6 @@ export const RepoDetails = (props: {repo: models.Repository; save?: (params: New
             }
         ];
 
-        if (repository.name) {
-            items.splice(1, 0, {
-                title: 'NAME',
-                view: repository.name
-            });
-        }
-
         if (repository.project) {
             items.splice(repository.name ? 2 : 1, 0, {
                 title: 'Project',
@@ -86,6 +84,7 @@ export const RepoDetails = (props: {repo: models.Repository; save?: (params: New
             })}
             save={async input => {
                 const params: NewHTTPSRepoParams = {...newRepo};
+                params.name = input.name || '';
                 params.username = input.username || '';
                 params.password = input.password || '';
                 save(params);

diff --git a/ui/src/app/settings/components/repos-list/repos-list.tsx b/ui/src/app/settings/components/repos-list/repos-list.tsx
@@ -470,9 +470,14 @@ export class ReposList extends React.Component<
                                                     <div className='argo-form-row'>
                                                         <FormField formApi={formApi} label='Type' field='type' component={FormSelect} componentProps={{options: ['git', 'helm']}} />
                                                     </div>
-                                                    {formApi.getFormState().values.type === 'helm' && (
+                                                    {(formApi.getFormState().values.type === 'helm' || formApi.getFormState().values.type === 'git') && (
                                                         <div className='argo-form-row'>
-                                                            <FormField formApi={formApi} label='Name' field='name' component={Text} />
+                                                            <FormField
+                                                                formApi={formApi}
+                                                                label={`Name ${formApi.getFormState().values.type === 'git' ? '(optional)' : ''}`}
+                                                                field='name'
+                                                                component={Text}
+                                                            />
                                                         </div>
                                                     )}
                                                     <div className='argo-form-row'>