feat: add fallback root params support for prefetch segment data routes #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add hasFallbackRootParams flag to ManifestRoute type - Add prefetchSegmentDataRoutes property to ManifestRoute type - Import buildInversePrefetchSegmentDataRoute function - Handle routes with fallback root params in build process - Generate inverse prefetch segment data routes for /_tree requests
|
✅ This pull request was succesfully scanned and it was determined that it does not contain any changes that present immediate security concerns. If you would still like for it to be reviewed by an expert from our reviewer community, you can submit it manually via the HackerOne PullRequest dashboard. ⏱️ Latest scan covered changes up to commit 3a75a65 (latest) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add support for generating prefetch segment data routes for pages with fallback root parameters.
Why?
When routes have fallback root parameters but no segment paths, the prefetch system wasn't generating the necessary rewrite rules. This caused client-side navigation to fail for these routes because the
/_treerequests couldn't be properly rewritten to the prefetch RSC route.How?
hasFallbackRootParamsflag andprefetchSegmentDataRoutestoManifestRoutetype/_treepath when routes have fallback root paramsRelated Pull Request: vercel/vercel#13653
🔄 This is a mirror of upstream PR #82282