feat: wiring support for P-384 and P-521 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siacomuzzi
reviewed
Nov 15, 2024
src/mdoc/Verifier.ts
Outdated
| const ephemeralMacKey = await calculateEphemeralMacKey( | ||
| options.ephemeralPrivateKey, | ||
| deviceKeyRaw, | ||
| options.sessionTranscriptBytes, | ||
| kty, | ||
| crv, |
There was a problem hiding this comment.
deviceKeyRaw and kty/crv are the same COSE key, right?
What if we pass deviceKeyCoseKey to the calculateEphemeralMacKey function and there is where we convert it to raw/jwk ?
siacomuzzi
reviewed
Nov 15, 2024
src/mdoc/model/DeviceResponse.ts
Outdated
|
|
||
| const ephemeralMacKey = await calculateEphemeralMacKey( | ||
| key, | ||
| this.ephemeralPublicKey, | ||
| sessionTranscriptBytes, | ||
| kty, | ||
| crv, |
There was a problem hiding this comment.
same as previous comment
siacomuzzi
approved these changes
Nov 15, 2024
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the possibility to compute MAC authentications with other NIST elliptic curves.
The curve used is chosen to be the one the private key is defined on:
When calculating the MAC, this is the device private key.
When verifying it, this is the reader private key.