Fix bug when canceling WebAuth flow #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
force-pushed
the
fix-npe-on-webauth-cancel
branch
from
ce9449f to
38ca0e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent canceled authentication from reaching the
WebAuthProvider.resume()method.The important lines are: https://github.com/auth0/Auth0.Android/pull/120/files#diff-101f8235cd64f6d21cfc3fc82d610bd5R25 and https://github.com/auth0/Auth0.Android/pull/120/files#diff-101f8235cd64f6d21cfc3fc82d610bd5R33. The remaining diff is just updating the tests according to that change.
Fixes #119