Allow to override default timeouts for Http Client #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
reviewed
Dec 3, 2018
| @@ -58,6 +63,12 @@ private void enableLogging(OkHttpClient client) { | |||
| client.interceptors().add(interceptor); | |||
| } | |||
|
|
|||
| private void setTimeout(OkHttpClient client, int timeout){ | |||
| client.setConnectTimeout(timeout, TimeUnit.SECONDS); | |||
| client.setReadTimeout(timeout, TimeUnit.SECONDS); | |||
There was a problem hiding this comment.
I believe it should only allow to change the "connect timeout" value, that would mean the time it takes for the server to acknowledge our request. The other 2 could extend the total request time far more than necessary. What's the justification to change the others?
There was a problem hiding this comment.
You are correct this was improperly implemented. It should give the user the ability to update each timeout individually. For our purposes when I made the change having all timeouts set to the same value was good enough.
I updated the code to allow setting each timeout individually.
auth0/src/test/java/com/auth0/android/request/internal/OkHttpClientFactoryTest.java
Outdated
Show resolved
Hide resolved
auth0/src/test/java/com/auth0/android/request/internal/OkHttpClientFactoryTest.java
Outdated
Show resolved
Hide resolved
auth0/src/test/java/com/auth0/android/request/internal/OkHttpClientFactoryTest.java
Outdated
Show resolved
Hide resolved
lbalmaceda
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the ability to optionally override the default 10 second timeout of the OkHttpClient