Migrate Public API to Kotlin [SDK-2193] #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
force-pushed
the
mv-to-kotlin
branch
from
bc9e34f to
7443ec2
Compare
jimmyjames
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR migrates public Java classes into Kotlin classes, making the following updates:
@VisibleForTestingnow includes the desired method visibility argumentNote to the reviewer: Prefer reviewing by commits, as each will migrate 1 class or a set of related classes.
References
See SDK-2193
Testing
Where possible, I tried not to change the unit tests to ensure the compatibility did not change. Where the
internalvisibility modifier was used, Java test classes needed to be updated to Kotlin.The only case in which tests were removed was when they were testing what happened when a
nullvalue was passed to a method that accepted a non-null argument. This in Kotlin throws an exception, as the compiler prevents from calling the methods in such a way.