Enforce the "openid" scope for the WebAuthProvider #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
commented
Jan 8, 2021
| @@ -322,7 +322,7 @@ public class WebAuthProviderTest { | |||
| val uri = | |||
| intentCaptor.firstValue.getParcelableExtra<Uri>(AuthenticationActivity.EXTRA_AUTHORIZE_URI) | |||
| MatcherAssert.assertThat(uri, `is`(notNullValue())) | |||
| MatcherAssert.assertThat(uri, UriMatchers.hasParamWithValue("scope", "profile super_scope")) | |||
| MatcherAssert.assertThat(uri, UriMatchers.hasParamWithValue("scope", "profile super_scope openid")) | |||
There was a problem hiding this comment.
since the scope is now enforced, I needed to update these tests
jimmyjames
previously approved these changes
Jan 8, 2021
|
@jimmyjames holding off this one until we decide if a different "default scope" should be set when no scope is given by the developer. The enforcement of "openid" will still be made. |
lbalmaceda
force-pushed
the
ft-enforce-scope
branch
from
7768b14 to
e2a7218
Compare
lbalmaceda
force-pushed
the
ft-enforce-scope
branch
from
e2a7218 to
84dd717
Compare
jimmyjames
approved these changes
Jan 11, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR enforces the scope of "openid", required as part of the ID Token validation that happens during Web Auth.