Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed pull_request_target to pull_request #675

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Changed pull_request_target to pull_request #675

merged 1 commit into from
Oct 9, 2024

Conversation

arpit-jn
Copy link
Contributor

@arpit-jn arpit-jn commented Oct 4, 2024

Changes

Please describe both what is changing and why this is important. Include:

  • Change pull_request_target to pull_request for better security.
  • Remove the authorize job from the list of jobs defined in that workflow.
  • Remove the dependency on authorize job for other jobs in that workflow by looking for the line needs: authorize.

Checklist

@arpit-jn arpit-jn merged commit dc00916 into main Oct 9, 2024
3 of 4 checks passed
@arpit-jn arpit-jn deleted the security-ci-pull_request_target-1 branch October 9, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmathew92 pmathew92 pmathew92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arpit-jn @pmathew92