-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enterprise single domain support #343
Conversation
Removed red auth routing in EDP and tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also we need to find a better name for EnterpriseDomainPresenter
@@ -26,7 +26,7 @@ import UIKit | |||
public class AuthStyle { | |||
|
|||
/// Name that will be used for titles. e.g. 'Login with Auth0' | |||
public let name: String | |||
public var name: String |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why var
?
@@ -62,7 +62,7 @@ public protocol ConnectionBuildable: Connections { | |||
- parameter name: name of the connection | |||
- parameter domain: array of enterprise domains | |||
*/ | |||
mutating func enterprise(name name: String, domains: [String]) | |||
mutating func enterprise(name name: String, domains: [String], style: AuthStyle) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to have a way to add a new enterprise connection without defining an AuthStyle
Customised login/signup titles
No description provided.