Enterprise single domain support #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed red auth routing in EDP and tests
hzalaz
suggested changes
Nov 23, 2016
| @@ -26,7 +26,7 @@ import UIKit | |||
| public class AuthStyle { | |||
|
|
|||
| /// Name that will be used for titles. e.g. 'Login with Auth0' | |||
| public let name: String | |||
| public var name: String | |||
| @@ -62,7 +62,7 @@ public protocol ConnectionBuildable: Connections { | |||
| - parameter name: name of the connection | |||
| - parameter domain: array of enterprise domains | |||
| */ | |||
| mutating func enterprise(name name: String, domains: [String]) | |||
| mutating func enterprise(name name: String, domains: [String], style: AuthStyle) | |||
There was a problem hiding this comment.
We need to have a way to add a new enterprise connection without defining an AuthStyle
Customised login/signup titles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.