Added onUserSignupBlock to A0LockViewController #161
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
Due to limitations with the Sign Up UI in the
A0LockViewController
, we had been unable to use it because we need to capture additional fields however the client still wanted a way to access the Sign-Up interface from within theA0LockViewController
(so that the users don't miss things like social sign in).I come up with a solution to add a
onUserSignupBlock
block (similar toonUserDismissBlock
) allowing developers to provide an override point upon the user selecting the Sign Up button.If
nil
(default), the SDK will work like it did previously and present the interface provided by the app however if the developer sets this block, upon the user selecting the Sign Up button, the block will be executed instead.This means that we can do something like the following:
Would be great to get it merged back into the main branch so that we can still receive other updates without having to manually merge into our own fork.
Thanks