Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse when password should include all sets error message #180

Merged
merged 1 commit into from
Oct 16, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion Lock/Tests/A0PasswordStrengthErrorHandlerSpec.m
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
static NSString *LenghtError = @"At least 10 characters in length.";
static NSString *IdenticalCharacterError = @"No more than 2 identical characters in a row (e.g., \"aaa\" not allowed).";
static NSString *CharacterSetError = @"Contain at least 3 of the following 4 types of characters:";
static NSString *CharacterSetAllError = @"Should contain:";
static NSString *LowerCaseSet = @"lower case letters (a-z)";
static NSString *UpperCaseSet = @"upper case letters (A-Z)";
static NSString *NumberSet = @"numbers (i.e. 0-9)";
Expand Down Expand Up @@ -62,7 +63,7 @@
expect([handler localizedMessageFromError:error]).to.contain(IdenticalCharacterError);
});

it(@"should return message for character set error", ^{
it(@"should return message for contains at least character set error", ^{
NSError *error = createError([builder errorWithFailingRules:@[@"containsAtLeast"]]);
NSString *message = [handler localizedMessageFromError:error];
expect(message).to.contain(CharacterSetError);
Expand All @@ -72,4 +73,14 @@
expect(message).to.contain(SpecialCharacterSet);
});

it(@"should return message for character should contain set error", ^{
NSError *error = createError([builder errorWithFailingRules:@[@"shouldContain"]]);
NSString *message = [handler localizedMessageFromError:error];
expect(message).to.contain(CharacterSetAllError);
expect(message).to.contain(LowerCaseSet);
expect(message).to.contain(UpperCaseSet);
expect(message).to.contain(NumberSet);
expect(message).to.contain(SpecialCharacterSet);
});

SpecEnd
27 changes: 27 additions & 0 deletions Lock/Tests/PasswordStrengthError.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,33 @@
"verified": false
},
{
"code": "shouldContain",
"items": [
{
"code": "lowerCase",
"message": "lower case letters (a-z)",
"verified": false
},
{
"code": "upperCase",
"message": "upper case letters (A-Z)",
"verified": false
},
{
"code": "numbers",
"message": "numbers (i.e. 0-9)",
"verified": false
},
{
"code": "specialCharacters",
"message": "special characters (e.g. !@#$%^&*)",
"verified": false
}
],
"message": "Should contain:",
"verified": false
},
{
"code": "identicalChars",
"format": [
2,
Expand Down
2 changes: 1 addition & 1 deletion Pod/Classes/Core/A0PasswordStrengthErrorHandler.m
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ - (NSString *)localizedMessageFromError:(NSError *)error {
if (![rule[@"verified"] boolValue]) {
if ([ruleCode isEqualToString:@"lengthAtLeast"]) {
[errors addObject:[self lengthMessageFromRule:rule]];
} else if ([ruleCode isEqualToString:@"containsAtLeast"]) {
} else if ([ruleCode isEqualToString:@"containsAtLeast"] || [ruleCode isEqualToString:@"shouldContain"]) {
[errors addObject:[self characterSetMessageFromRule:rule]];
} else if ([ruleCode isEqualToString:@"identicalChars"]) {
[errors addObject:[self identicalCharacterMessageFromRule:rule]];
Expand Down