Navigate to Login screen after ResetPassword and Signup events #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure .Login is allowed
hzalaz
suggested changes
Jan 11, 2017
| @@ -73,6 +73,7 @@ class DatabaseForgotPasswordPresenter: Presentable, Loggable { | |||
| } else { | |||
| let message = "We've just sent you an email to reset your password".i18n(key: "com.auth0.lock.database.forgot.success.message", comment: "forgot password email sent") | |||
| self.messagePresenter?.showSuccess(message) | |||
| guard !self.options.allow.contains(.Login) else { return self.navigator.navigate(.root) } | |||
There was a problem hiding this comment.
A better use of guard is to remove the unnecessary or uncommon branches of a flow. In this case the odd branch is when login is not allowed so we can either return nothing or do an old-fashioned else since it's more readable for this case because of the double negation.
|
And tests? |
Added ForgotPasssord auto navigate test
cocojoe
force-pushed
the
feature_login_screen_after_actions
branch
from
15bc70e
to
e4ee112
Compare
hzalaz
approved these changes
Jan 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure .Login is allowed