Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto close on success event behaviour and customization #370

Merged
merged 5 commits into from
Jan 17, 2017
Merged

Auto close on success event behaviour and customization #370

merged 5 commits into from
Jan 17, 2017

Commits on Jan 16, 2017

  1. Dismiss Lock on .Signup when .Login not present 

    Dismiss Lock on .ResetPassword when .Login not present
Added ForgetPassword event handling to Dispatcher
Added Dispatch/Dismiss tests to Database Password Interactor
    @cocojoe
    cocojoe committed Jan 16, 2017
    Configuration menu
    Copy the full SHA
    a38db6b View commit details
    Browse the repository at this point in the history

  2. Refactor dismissLock flag into dispatch func 

    Remove success banner display when auto closing
Added autoClose to options for specifying mode auto closing
Added validation for 'impossible to close Lock' miss configurations
Added more dispatch tests in DatabaseInteractor and DatabasePasswordInteractor
Login will always auto close for all connection types
    @cocojoe
    cocojoe committed Jan 16, 2017
    Configuration menu
    Copy the full SHA
    c996a6d View commit details
    Browse the repository at this point in the history

  3. Dispatch Timeout Travis Test

    @cocojoe
    cocojoe committed Jan 16, 2017
    Configuration menu
    Copy the full SHA
    0db93b5 View commit details
    Browse the repository at this point in the history

  4. Refactored ObserverStore dismissLock management 

    Updated Tests
    @cocojoe
    cocojoe committed Jan 16, 2017
    Configuration menu
    Copy the full SHA
    c0706e8 View commit details
    Browse the repository at this point in the history

  5. Moved dismissLock logic into ObserverStore case 

    Changed autoClose flag to Bool
Updated Tests
Removed Options from DatabasePasswordInteractor
Login now follows autoClose rules
Login success message added
DatabaseInteractor tests Added
Dispatcher related tests unified into ObserverStore tests
    @cocojoe
    cocojoe committed Jan 16, 2017
    Configuration menu
    Copy the full SHA
    8c75bce View commit details
    Browse the repository at this point in the history