Added configurationBaseURL option for Custom Domains support
#505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocojoe
force-pushed
the
added-option-baseurl
branch
from
4ed7306
to
3c525b6
Compare
Added `configurationBase` convenience setter Added Tests
cocojoe
force-pushed
the
added-option-baseurl
branch
from
3c525b6
to
938a949
Compare
mariancerny
reviewed
Jun 6, 2018
| var configurationBase: String? { | ||
| get { | ||
| guard let url = self.configurationBaseURL else { return nil } | ||
| return url.absoluteString |
There was a problem hiding this comment.
Those two lines can be shortened to return self.configurationBaseURL?.absoluteString.
There was a problem hiding this comment.
Sure could, this is for clarity.
There was a problem hiding this comment.
TBH I find it more clear (not knowing swift) with a single line. But it's up to you @cocojoe .
lbalmaceda
reviewed
Jun 6, 2018
Lock/OptionBuildable.swift
Outdated
| return url.absoluteString | ||
| } | ||
| set { | ||
| guard let value = newValue, let url = URL(string: value) else { return } // FIXME: log error |
There was a problem hiding this comment.
There's a FIXME here. Are you going to add it in this PR?
There was a problem hiding this comment.
Don't feel these are relevant anymore tbh
LockTests/OptionsSpec.swift
Outdated
| @@ -256,6 +259,11 @@ class OptionsSpec: QuickSpec { | |||
| expect(options.supportURL?.absoluteString) == "https://auth0.com/docs" | |||
| } | |||
|
|
|||
| it("should set baseURL") { | |||
There was a problem hiding this comment.
please use configurationBaseURL instead (like in the other test)
| var configurationBase: String? { | ||
| get { | ||
| guard let url = self.configurationBaseURL else { return nil } | ||
| return url.absoluteString |
There was a problem hiding this comment.
TBH I find it more clear (not knowing swift) with a single line. But it's up to you @cocojoe .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #504