Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LockViewController dismissal when presented as a popup #647

Merged
merged 6 commits into from
Apr 13, 2021

Commits on Dec 1, 2020

  1. Configure interactive dismissal of the Lock popup

    On iPad, with a presentation style of .formSheet, the LockViewController
    could be dismissed by simply tapping outside the bounds of the modal,
    without regard for the `closable` [1] option.
    
    Setting `isModalInPresentation` [2] based on `closable` allows controlling
    whether or not UIKit should prevent the interactive dismissal of the popup.
    
    [1] https://auth0.com/docs/libraries/lock-swift/lock-swift-configuration-options#closable
    [2] https://developer.apple.com/documentation/uikit/uiviewcontroller/3229894-ismodalinpresentation
    agirault authored and Alexis Girault committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    c4b95ca View commit details
    Browse the repository at this point in the history
  2. Dispatch cancel callback when the Lock view is interactively dismissed

    Call onCancel when the Lock view controller modal is dismissed by the user
    (by tapping outside its bounds on iPad).
    
    This is not called when it's dismissed programmatically:
    https://developer.apple.com/documentation/uikit/uiadaptivepresentationcontrollerdelegate/3229889-presentationcontrollerdiddismiss
    Alexis Girault committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    817d769 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2020

  1. Configuration menu
    Copy the full SHA
    83315ff View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2021

  1. Configuration menu
    Copy the full SHA
    459823d View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2021

  1. Configuration menu
    Copy the full SHA
    7162700 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b84bdcb View commit details
    Browse the repository at this point in the history