Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test dependencies not resolve when installing with SPM [SDK-2601] #671

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Jun 3, 2021

Changes

Lock.swift relies on the Quick and Nimble test libraries for its tests, and it's pinning their version range to a particular major. Currently, when installing Lock.swift with the Swift Package Manager it will resolve both test dependencies even though they're not used in the actual library. This opens up the possibility of conflict if the app the libraries are imported into is using another major version of Quick/Nimble.
SPM has, since swift 5.2 (released with Xcode 11.4), supported a way to have the test dependencies not resolve if they're not used. Since we already dropped support for Xcode < 11.4, this will not be a breaking change.

References

Fixes auth0/SimpleKeychain#107
Related to auth0/SimpleKeychain#108
Related to auth0/JWTDecode.swift#125
Related to auth0/Auth0.swift#476

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket requested a review from a team as a code owner June 3, 2021 23:36
@Widcket Widcket changed the title Include the package name of the test dependencies Include the package name of the test dependencies [SDK-2601] Jun 3, 2021
@Widcket Widcket changed the title Include the package name of the test dependencies [SDK-2601] Make test dependencies not resolve when installing with SPM [SDK-2601] Jun 3, 2021
@Widcket Widcket merged commit 63616ca into master Jun 4, 2021
@Widcket Widcket deleted the test/spm-deps branch June 4, 2021 15:40
@Widcket Widcket modified the milestones: vNext, 2.22.3 Jun 7, 2021
@Widcket Widcket mentioned this pull request Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependency (Quick)
2 participants