Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed warnings #680

Merged
merged 2 commits into from
Sep 20, 2021
Merged

Fixed warnings #680

merged 2 commits into from
Sep 20, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Sep 20, 2021

Changes

This PR fixes warnings, as produced by the Xcode 13 swift compiler. Mainly the ones caused by using class to constrain protocols instead of AnyObject: https://forums.swift.org/t/class-only-protocols-class-vs-anyobject/11507/12

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket requested a review from a team as a code owner September 20, 2021 21:03
@Widcket Widcket added the review:tiny Tiny review label Sep 20, 2021
@Widcket Widcket merged commit 5359565 into master Sep 20, 2021
@Widcket Widcket deleted the fix/xcode13-warnings branch September 20, 2021 22:06
@Widcket Widcket mentioned this pull request Sep 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evansims evansims evansims approved these changes

Assignees
No one assigned
Labels
review:tiny Tiny review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Widcket @evansims