Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to input code when using magic links [SDK-2826] #684

Merged
merged 2 commits into from
Oct 5, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Oct 4, 2021

Changes

This PR adds the possibility to input the passwordless code manually when using magic links. Such functionality was already available on Lock.Android:

default.mov

References

Closes #670

Testing

This change was tested manually on both an iPhone 13 simulator (iOS 15) and a physical iPhone 11 Pro (iOS 15), using Xcode 13.

RPReplay_Final1633390696.MP4
  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket requested a review from a team as a code owner October 4, 2021 23:46
@Widcket Widcket merged commit aaa1ef0 into master Oct 5, 2021
@Widcket Widcket deleted the feature/code-magic-links branch October 5, 2021 14:37
@Widcket Widcket mentioned this pull request Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Magic Link + code facility
2 participants